From 7483ed96c625402b549bdaa20582ca4abbe8b70c Mon Sep 17 00:00:00 2001 From: Corey Farrell Date: Thu, 5 Jul 2018 16:38:48 -0400 Subject: [PATCH] fix: use uuid/v4 to generate unique identifiers. (#883) --- index.js | 8 ++------ package-lock.json | 7 +++---- package.json | 4 ++-- 3 files changed, 7 insertions(+), 12 deletions(-) diff --git a/index.js b/index.js index cd8b6b1dd..dded71d33 100755 --- a/index.js +++ b/index.js @@ -12,7 +12,6 @@ const Hash = require('./lib/hash') const libCoverage = require('istanbul-lib-coverage') const libHook = require('istanbul-lib-hook') const libReport = require('istanbul-lib-report') -const md5hex = require('md5-hex') const mkdirp = require('make-dir') const Module = require('module') const onExit = require('signal-exit') @@ -22,6 +21,7 @@ const resolveFrom = require('resolve-from') const rimraf = require('rimraf') const SourceMaps = require('./lib/source-maps') const testExclude = require('test-exclude') +const uuid = require('uuid/v4') var ProcessInfo try { @@ -363,11 +363,7 @@ NYC.prototype.wrap = function (bin) { return this } -NYC.prototype.generateUniqueID = function () { - return md5hex( - process.hrtime().concat(process.pid).map(String) - ) -} +NYC.prototype.generateUniqueID = uuid NYC.prototype.writeCoverageFile = function () { var coverage = coverageFinder() diff --git a/package-lock.json b/package-lock.json index 07a0a8766..739b520bd 100644 --- a/package-lock.json +++ b/package-lock.json @@ -7825,10 +7825,9 @@ "dev": true }, "uuid": { - "version": "3.2.1", - "resolved": "https://registry.npmjs.org/uuid/-/uuid-3.2.1.tgz", - "integrity": "sha512-jZnMwlb9Iku/O3smGWvZhauCf6cvvpKi4BKRiliS3cxnI+Gz9j5MEpTz2UFuXiKPJocb7gnsLHwiS05ige5BEA==", - "dev": true + "version": "3.3.2", + "resolved": "https://registry.npmjs.org/uuid/-/uuid-3.3.2.tgz", + "integrity": "sha512-yXJmeNaw3DnnKAOKJE51sL/ZaYfWJRl1pK9dr19YFCu0ObS231AB1/LbqTKRAQ5kw8A90rA6fr4riOUpTZvQZA==" }, "validate-npm-package-license": { "version": "3.0.3", diff --git a/package.json b/package.json index d21885b4a..56db8550e 100644 --- a/package.json +++ b/package.json @@ -89,13 +89,13 @@ "istanbul-lib-source-maps": "^2.0.0", "istanbul-reports": "^1.5.0", "make-dir": "^1.3.0", - "md5-hex": "^2.0.0", "merge-source-map": "^1.1.0", "resolve-from": "^4.0.0", "rimraf": "^2.6.2", "signal-exit": "^3.0.2", "spawn-wrap": "^1.4.2", "test-exclude": "^5.0.0", + "uuid": "^3.3.2", "yargs": "11.1.0", "yargs-parser": "^9.0.2" }, @@ -140,13 +140,13 @@ "istanbul-lib-source-maps", "istanbul-reports", "make-dir", - "md5-hex", "merge-source-map", "resolve-from", "rimraf", "signal-exit", "spawn-wrap", "test-exclude", + "uuid", "yargs", "yargs-parser" ]