feat: add processinfo index, add externalId #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
processinfo-index
branch
3 times, most recently
from
e92d40e
to
d5a114c
Compare
coreyfarrell
requested changes
Apr 5, 2019
isaacs
force-pushed
the
processinfo-index
branch
2 times, most recently
from
e4bfd9f
to
2ffe591
Compare
Docs and tests still TK. Future commit message follows. --- feat: add processinfo index, add externalId If a NYC_PROCESSINFO_EXTERNAL_ID environment variable is set, then it is saved in the processinfo as `externalId`. BREAKING CHANGE: This adds a file named 'index.json' to the .nyc_output/processinfo directory, which has a different format from the other files in this dir. Furthermore, when this file is generated, some additional helpful metadata is memoized to the processinfo json files, to minimize the cost of repeated generation. (This isn't necessarily a breaking change, but it is an update to the de facto schema for those files.) As soon as possible, index generation and process tree display should be migrated out to a new 'istanbul-lib-processinfo' library. This opens the door to add features in the v14 release family to improve support for partial/resumed test runs and file watching. - When a process is run with --clean=false and a previously seen externalId, clear away all the coverage files in the set for that externalId. - When a file is changed, a test runner can use the index to determine which tests (by externalId) ought to be re-run.
- Adds a NYC_PROCESS_ID to environment
- Adds `parent` to processInfo object, a uuid referring to parent.
- Rebase onto processinfo-numeric-pids branch
- Avoid re-writing the processinfo/{uuid}.json files
Next:
- Update process tree output to rely on process index instead of
duplicating effort.
Also, remove some unnecessary fields from process infos
isaacs
force-pushed
the
processinfo-index
branch
from
feabd74
to
6fa4332
Compare
coreyfarrell
reviewed
Apr 6, 2019
coreyfarrell
approved these changes
Apr 6, 2019
|
I think keeping it out of the docs is sensible for now. I've been taking notes in my early sketch of istanbul-lib-processinfo anyway, but I'll probably put that off until tap v13 is finished, since I'll be able to test out some of the concepts ad hoc and see what works. There may be some additional tweaks necessary, but I don't think the data structure needs to change from what it is right now, so we can avoid any semver major changes in the near future. Would you like to squash, or shall I do the honors? |
Lets give it a couple days to see if @addaleax has any comments since she originally implemented the processinfo functionality. If we don't get any objections I'll squash and merge. Probably do a second pre-release of nyc 14 by the middle of the week. |
addaleax
approved these changes
Apr 6, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A WIP COMMIT FOR REVIEW ONLY, DO NOT MERGE
[ ] docsfeat: add processinfo index, add externalId
If a NYC_PROCESSINFO_EXTERNAL_ID environment variable is set, then it is
saved in the processinfo as
externalId.BREAKING CHANGE: This adds a file named 'index.json' to the
.nyc_output/processinfo directory, which has a different format from the
other files in this dir.
Furthermore, when this file is generated, some additional helpful
metadata is memoized to the processinfo json files, to minimize the cost
of repeated generation. (This isn't necessarily a breaking change, but
it is an update to the de facto schema for those files.)
As soon as possible, index generation and process tree display should be
migrated out to a new 'istanbul-lib-processinfo' library.
This opens the door to add features in the v14 release family to improve
support for partial/resumed test runs and file watching.
externalId, clear away all the coverage files in the set for that
externalId.
which tests (by externalId) ought to be re-run.