fix: Exit with code 1 when nyc doesn't know what to do. #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaKXz
reviewed
Apr 17, 2019
coreyfarrell
force-pushed
the
unknown-main-command
branch
from
9029c20
to
2ff6dba
Compare
JaKXz
reviewed
Apr 17, 2019
bcoe
approved these changes
Apr 17, 2019
coreyfarrell
force-pushed
the
unknown-main-command
branch
from
2ff6dba
to
d44a260
Compare
When nyc is not told to do anything this is an error. We already printed the help message to stderr, now we exit with code 1 to indicate that nyc exited without doing anything. Add a test to cover this edge case and verify that both `nyc` and `nyc --help` produce output as expected to stdout and stderr, exit with the proper code.
coreyfarrell
force-pushed
the
unknown-main-command
branch
from
d44a260
to
6599f11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nyc is not told to do anything this is an error. We already
printed the help message to stderr, now we exit with code 1 to indicate
that nyc exited without doing anything.
Add a test to cover this edge case and verify that both
nycandnyc --helpproduce output as expected to stdout and stderr, exit with theproper code.