Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nyc 15.x / next version of istanbul libraries #1104

Closed
12 of 13 tasks
coreyfarrell opened this issue May 7, 2019 · 8 comments
Closed
12 of 13 tasks

nyc 15.x / next version of istanbul libraries #1104

coreyfarrell opened this issue May 7, 2019 · 8 comments

Comments

@coreyfarrell
Copy link
Member

coreyfarrell commented May 7, 2019

The following major/breaking changes are currently planned for nyc 15 and the next version of istanbul libraries:

This tracking ticket will be updated as progress is made, it will be closed when nyc@15.0.0 is released.

@coreyfarrell

This comment has been minimized.

@mightyiam
Copy link

Thank you for all of the work, @coreyfarrell and everyone else who might have contributed.

Trying to be helpful by adding a PR here. It has CI.
https://github.com/mightyiam/shields-badge-data/pull/109

@mightyiam
Copy link

@coreyfarrell
Copy link
Member Author

nyc 15.0.0-beta.1 is now published to npm next tag. Updated change-log below.


⚠ BREAKING CHANGES

  • The flow and jsx parser plugins are no longer
    enabled by default.
  • Node.js 8 is now required to run nyc
  • Remove NYC_ROOT_ID and NYC_INSTRUMENTER environmental
    variables.
  • The root field has been removed from processinfo
    files.

Bug Fixes

Features

@coreyfarrell coreyfarrell pinned this issue Dec 4, 2019
mroderick added a commit to mroderick/plete that referenced this issue Dec 8, 2019
Lock node to version 10, as nyc doesn't work well with 12

See istanbuljs/nyc#1104
@coreyfarrell
Copy link
Member Author

nyc 15.0.0 and babel-plugin-istanbul 6.0.0 are now published to npm under the next tag. Some minor changes to reporting and some internal changes since the last update here. Any testing would be appreciated, let me know of any issues.

The intent is for these to become the final releases. CHANGELOG is now updated in the master branch.

@coreyfarrell
Copy link
Member Author

nyc 15.0.0 and babel-plugin-istanbul 6.0.0 are now latest on npm.

@coreyfarrell coreyfarrell unpinned this issue Dec 23, 2019
@harpal-sgh
Copy link

I am getting 0% for statements, lines, functions -
===================== Coverage summary ===============================
Statements : 0% ( 0/34 )
Branches : 100% ( 0/0 )
Functions : 0% ( 0/4 )
Lines : 0% ( 0/34 )

nyc": "^15.0.0",

"scripts": {
"test": "serverless-bundle test",
"test-nyc": "nyc npm test"
},

I do have few tests for all the files.

@Codex-
Copy link

Codex- commented Mar 17, 2020

Had that as well but found it was a bad setting in .nycrc that we had from the old days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants