feat(experimental): Support using --all with node.js ES modules
#1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `--all` to collect initial coverage from fils which node.js recognizes as ES modules (`.mjs` files and conditionally `.js` files). Previously this would cause node.js to produce an `ERR_REQUIRE_ESM` error. This does not enable collection of coverage during actual tests, for that you must use the experimental `@istanbuljs/esm-loader-hook`.
coreyfarrell
force-pushed
the
es-modules-all
branch
from
169d04e
to
3308760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
--allto collect initial coverage from fils which node.jsrecognizes as ES modules (
.mjsfiles and conditionally.jsfiles).Previously this would cause node.js to produce an
ERR_REQUIRE_ESMerror.
This does not enable collection of coverage during actual tests, for that
you must use the experimental
@istanbuljs/esm-loader-hook.