Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use uuid/v4 to generate unique identifiers. #883

Merged
merged 1 commit into from Jul 5, 2018
Merged

fix: Use uuid/v4 to generate unique identifiers. #883

merged 1 commit into from Jul 5, 2018

Conversation

coreyfarrell
Copy link
Member

This allows nyc to be be used on FIPS systems which have disabled md5.

Fixes #869

@coreyfarrell
fix: Use uuid/v4 to generate unique identifiers.
9a37bb9 
This allows nyc to be be used on FIPS systems which have disabled md5.

Fixes istanbuljs#869
@coreyfarrell coreyfarrell mentioned this pull request Jul 5, 2018
Closed
bcoe
bcoe approved these changes Jul 5, 2018
View reviewed changes
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great to me 👍

@bcoe bcoe merged commit 7483ed9 into istanbuljs:master Jul 5, 2018
@coreyfarrell coreyfarrell deleted the use-uuid branch July 5, 2018 20:44
@lappet
Copy link

lappet commented Jul 19, 2018 •
edited

Thanks for this! However, it looks like npm is fetching a stale version when I specify 13.0.0; nyc still uses md5. Should I create an issue for that? I am getting around it by directly pointing to this git repository.

@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coreyfarrell @lappet @bcoe