Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dose nyc support yaml format configuration file? #892

Closed
poppinlp opened this issue Jul 17, 2018 · 6 comments
Closed

Dose nyc support yaml format configuration file? #892

poppinlp opened this issue Jul 17, 2018 · 6 comments

Comments

@poppinlp
Copy link

I found configuration file named .nycrc in your README which is in JSON format. So dose this support yaml configuration file?

@coreyfarrell
Copy link
Member

Only JSON is supported.

@poppinlp
Copy link
Author

OK. Thanks. Do you think you need a PR for that? :)

@coreyfarrell
Copy link
Member

I'd be open to this if it can be done without bloating NYC. Specifically I do not want npm install nyc to actually include modules needed to process YAML (or other format types). Instead I'd be looking for NYC to report an error if .nycrc.yaml is found but the module needed to load it is not installed. So npm install --save-dev nyc js-yaml would be needed.

I think we'll need something similar to interpret (but not exactly the same). interpret is designed to hook the node.js require() funciton, we cannot do that. So NYC cannot use require-yaml, it would need to use a module that simply loads YAML without touching the node.js module loader (js-yaml I think?).

@poppinlp
Copy link
Author

poppinlp commented Aug 2, 2018

OK. I agree with you.
I'll think about what you said. And yep, i think js-yaml is good.

@stale stale bot added the wontfix label Jan 5, 2019
@JaKXz
Copy link
Member

JaKXz commented Jan 28, 2019

@poppinlp are you still interested in writing that PR?

@JaKXz JaKXz added stale and removed wontfix labels Feb 5, 2019
@stale stale bot removed the stale label Feb 5, 2019
@istanbuljs istanbuljs deleted a comment from stale bot Apr 4, 2019
@furudean
Copy link
Contributor

Implemented in #1054

@JaKXz can you close this issue?

@JaKXz JaKXz closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants