Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming for *-directory options #895

Closed
AndrewFinlay opened this issue Jul 24, 2018 · 2 comments · Fixed by #897
Closed

Consistent naming for *-directory options #895

AndrewFinlay opened this issue Jul 24, 2018 · 2 comments · Fixed by #897

Comments

@AndrewFinlay
Copy link
Contributor

Expected Behavior

Should be able to use --temp-dir --report-dir and/or --temp-directory --report-directory
Not a big issue but one that's annoying while configuring nyc, and it should be an easy fix.

Observed Behavior

Must use --temp-directory and --report-dir

Bonus Points! Code (or Repository) that Reproduces Issue

N/A

Forensic Information

Should be able to do this with a few yargs aliases, let me know if you'd like a PR

@coreyfarrell
Copy link
Member

I'm leaning towards adding a --temp-dir option and making --temp-directory deprecated, or at least undocumented. My preference is that we not have two officially documented ways. yargs is outside my area of knowledge so I'm unsure how this would be accomplished. If you'd like to submit a PR that would be nice.

@AndrewFinlay
Copy link
Contributor Author

Hi Corey,

I've put up a PR for this here, #897. It's pretty straight forward aside from how to test that the deprecated command still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants