Bug 913

[AGrzes]

Proposed fix for #913.
I created simple falling test and did small change to eliminate the issue.
Please let me know if any improvement is needed.

[bcoe]

@coreyfarrell @AGrzes this seems reasonable to me. tldr; you're proposing that files that fail the shouldInstrument test should not be processed during the --all step.

One question for you, I believe sometimes typescript files are laid out in a different directory, and than compiled in another folder, e.g., src/ which gets compiled into lib/; how would this effect include rules that reference lib/ and not src/.

[AGrzes]

My reasoning (regarding old code) id the following

  this.walkAllFiles(this.cwd, function (filename) {
    filename = path.resolve(_this.cwd, filename)
    _this.addFile(filename)
    var coverage = coverageFinder()
    var lastCoverage = _this.instrumenter().lastFileCoverage()
    if (lastCoverage) {
      filename = lastCoverage.path
    }
    if (lastCoverage && _this.exclude.shouldInstrument(filename)) {
      coverage[filename] = lastCoverage
    }
})

NYC.prototype.addFile = function (filename) {
  var relFile = path.relative(this.cwd, filename)
  var source = this._readTranspiledSource(path.resolve(this.cwd, filename))
  var instrumentedSource = this._maybeInstrumentSource(source, filename, relFile)

  return {
    instrument: !!instrumentedSource,
    relFile: relFile,
    content: instrumentedSource || source
  }
}

NYC.prototype._maybeInstrumentSource = function (code, filename, relFile) {
  var instrument = this.exclude.shouldInstrument(filename, relFile)
  if (!instrument) {
    return null
  }

  var ext, transform
  for (ext in this.transforms) {
    if (filename.toLowerCase().substr(-ext.length) === ext) {
      transform = this.transforms[ext]
      break
    }
  }

  return transform ? transform(code, {filename: filename, relFile: relFile}) : null
}

• the addFile is transpiling source (causing the issue reported by me).
• _maybeInstrumentSource will instrument the source based on shouldInstrument check.
• The result of instrumentation will be stored in coverage variable based on shouldInstrument check.
• In essence if shouldInstrument returns false then any instrumentation results are discarded so I believe my change does not change end result (in cases where there was no error during transpiling)

Regarding src and lib I'm not sure I get your question. Could you explain further?

[coreyfarrell]

This looks good to me.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[AGrzes]

Is there anything else to do / explain before this request can be merged?

[JaKXz]

Sorry @AGrzes this is great! going to merge now.

[bcoe]

should read:

"does not transpile files when not included"