Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidecar injection has n^2 behavior with large pods #44933

Closed
howardjohn opened this issue May 16, 2023 · 3 comments
Closed

Sidecar injection has n^2 behavior with large pods #44933

howardjohn opened this issue May 16, 2023 · 3 comments
Assignees
@howardjohn
Labels
lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while

Comments

@howardjohn
Copy link
Member

When a pod has lots of env vars, injection can take a long time. Looks polynomial. With 1000 env vars we are talking multiple seconds and GB of allocations.

The root cause is in the jsonpatch library we use. I am looking into upstream improvements to optimize.
@howardjohn howardjohn self-assigned this May 16, 2023
@howardjohn
Copy link
Member Author

Fix is in gomodules/jsonpatch#36. The library hasn't had updates in 2 years, so TBD how it will be received. We can fork if needed, the library is pretty small.

howardjohn added a commit to howardjohn/istio that referenced this issue May 16, 2023
@howardjohn
injection: add benchmark
c8c9f92 
This is for istio#44933.
@howardjohn howardjohn mentioned this issue May 16, 2023
Merged
istio-testing pushed a commit that referenced this issue May 16, 2023
@howardjohn
injection: add benchmark (#44935)
12ce4ff 
This is for #44933.
@istio-policy-bot
Copy link

🧭 This issue or pull request has been automatically marked as stale because it has not had activity from an Istio team member since 2023-05-16. It will be closed on 2023-08-29 unless an Istio team member takes action. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Aug 15, 2023
@howardjohn
Copy link
Member Author

fix merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@howardjohn howardjohn

Labels
lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@howardjohn @istio-policy-bot