Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy context API usage #110

Open
2 tasks
ioggstream opened this issue Dec 28, 2020 · 4 comments
Open
2 tasks

Legacy context API usage #110

ioggstream opened this issue Dec 28, 2020 · 4 comments
Labels
new-ui Issues in the new-ui branch priority=low
Projects

Comments

@ioggstream
Copy link
Collaborator

I expect

No warnings

Instead

  • Warning: Legacy context API has been detected within a strict-mode tree.
The old API will be supported in all 16.x releases, but applications using it should migrate to the new version.

Please update the following components: Transition
  • Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node

See

https://reactjs.org/docs/legacy-context.html

@ioggstream ioggstream added the new-ui Issues in the new-ui branch label Dec 28, 2020
@ioggstream ioggstream added this to To do in New UI Dec 28, 2020
@emilioSp
Copy link
Collaborator

emilioSp commented Dec 28, 2020

This is an annoying bug due to our base library used to create react components.
See also italia/form-pa#22

@sebbalex do we have a workaround? It's inside the Modal component from design-react-kit.

@ioggstream
Copy link
Collaborator Author

If it's not blocking, deprioritize it in this project. @emilioSp

@ioggstream
Copy link
Collaborator Author

@sebbalex is it ok to priority=low ?

@sebbalex
Copy link
Member

@sebbalex do we have a workaround? It's inside the Modal component from design-react-kit.

This is very annoying, it is caused by an unsafe use of lifecycle hooks in a dependency of reactstrap (base library for design-react-kit). As far as I know it should be fixed in next release.
@emilioSp we don't have a proper workaround...

@ioggstream yes, we can low priority for this. atm it's just a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-ui Issues in the new-ui branch priority=low
Projects
No open projects
New UI
To do
Development

No branches or pull requests

3 participants