Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix findBest types #502

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix findBest types #502

merged 1 commit into from
Aug 30, 2023

Conversation

conartist6
Copy link
Member

Fixes #501

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #502 (7dfb55a) into trunk (a33f6bb) will not change coverage.
The diff coverage is n/a.

❗ Current head 7dfb55a differs from pull request most recent head 7a335cb. Consider uploading reports for the commit 7a335cb to get more accurate results

@@           Coverage Diff           @@
##            trunk     #502   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files         235      235           
  Lines        1869     1869           
=======================================
  Hits         1855     1855           
  Misses         14       14

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@conartist6 conartist6 merged commit 1d7c1cb into trunk Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong TypeScript types for findBest and asyncFindBest
1 participant
@conartist6