Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linters? #615

Open
dacbd opened this issue Jun 24, 2022 · 9 comments · Fixed by #616
Open

Linters? #615

dacbd opened this issue Jun 24, 2022 · 9 comments · Fixed by #616
Labels
discussion Waiting for team decision

Comments

@dacbd
Copy link
Contributor

dacbd commented Jun 24, 2022

aka Restyled's PR spam triggers me...

thoughts on adding github/super-linter/slim as a check for PRs and removing Restyled.

I will note that, that the linter has a bit on a laundry list... see here

@dacbd dacbd added the discussion Waiting for team decision label Jun 24, 2022
@0x2b3bfa0
Copy link
Member

Note that we already have golangci-lint in place for the task directory. The iterative directory has been explicitly excluded because it has, effectively, a laundry list of issues.

Ma quel foglio che chiedete
per azzardo m'è cascato.
È la lista del bucato.

@0x2b3bfa0
Copy link
Member

skip-dirs:
- iterative

@dacbd
Copy link
Contributor Author

dacbd commented Jun 24, 2022

I missed that 🙈, does it work with deltas natively? Perhaps it's time to include it and as future tweaks come in part of the PRs will be cleanup.

@0x2b3bfa0
Copy link
Member

does it work with deltas natively?

If you mean --new-from-rev yes.

@0x2b3bfa0
Copy link
Member

Moved to #616

@0x2b3bfa0
Copy link
Member

Not sure if we need super-linter for a single language, but it's indeed a nice project.
Let's ask @iterative/cml for opinions; we'll surely get plenty. 😄

@dacbd
Copy link
Contributor Author

dacbd commented Jun 27, 2022

it also dectects various bits of shell scripting, GitHub actions, and others etc

@0x2b3bfa0
Copy link
Member

Sounds good. Let's lint, then. 🐑

@0x2b3bfa0 0x2b3bfa0 linked a pull request Jun 28, 2022 that will close this issue
@0x2b3bfa0
Copy link
Member

Note that running super-linter locally doesn't feel quite ergonomic. I hope we won't need to run a Docker container with a commit hook. 😈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Waiting for team decision
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants