Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when the view has a AVPlayerViewController #20

Open
PedroCavaleiro opened this issue Nov 16, 2022 · 2 comments
Open

Problem when the view has a AVPlayerViewController #20

PedroCavaleiro opened this issue Nov 16, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@PedroCavaleiro
Copy link

PedroCavaleiro commented Nov 16, 2022

Details

  • iOS Version: 16.1.1
  • Framework Version: Branch Main
  • Installed via SPM

I'm trying to create a list of videos, each entry has a video player but using the library AZVideoPlayer for fullscreen and PiP support

There's a issue where the HUD goes under the notch

I was able to find out that the problem probably lies in the AVPlayerViewController, I tried to implement a simpler version of the video player with the AVPlayerViewController and got the same result, no issues when using the native VideoPlayer

RPReplay_Final1668563545.mov

It's a bit hard to get a idea with the screen grab but the toast should cover the "Feed" word completely

I added the SPIndicator on the topmost view to see if it would helped but it doesn't

@PedroCavaleiro PedroCavaleiro added the bug Something isn't working label Nov 16, 2022
@PedroCavaleiro PedroCavaleiro mentioned this issue Nov 21, 2022
2 tasks
@gvizeu
Copy link

gvizeu commented Jul 18, 2023

Hi I had the same problem, as far I see weh you work with AVPlayer or AVPictureInPicture. Apple creates a UIWindow called PGHostedWindow that does not have safeAreaInsets. and this framework is using
UIApplication.shared.windows.first to get the safe area insets instead of
UIApplication.shared.connectedScenes .filter { $0.activationState == .foregroundActive } .first(where: { $0 is UIWindowScene }) .flatMap({ $0 as? UIWindowScene })?.windows .first(where: \.isKeyWindow)

what I suggest is create a fork with this change until they fix it :)

@ivanvorobei
Copy link
Owner

Happy for any community changes. Soon will move this repo to pack with indicators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants