Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline Message #29

Open
nahn20 opened this issue Mar 3, 2024 · 2 comments
Open

Multiline Message #29

nahn20 opened this issue Mar 3, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@nahn20
Copy link

nahn20 commented Mar 3, 2024

Feature Description
Currently, the behavior for long messages is to truncate the text to fit on one line. I believe it would make more sense for the view to increase in height based on the dimensions of its contents to allow for more lines of the message text to show. In order to maintain backwards compatibility, I think the default number of lines for the message should be 1, and the container should expand when the number of lines is modified to be greater than 1 (and has multiple lines).

From what I can tell, areaHeight is currently constant and only used in one place. With some preliminary testing, it seems increasing this value here increase the size of the container, so I image one could just measure the height of the children instead of using areaHeight.

@nahn20 nahn20 added the enhancement New feature or request label Mar 3, 2024
@nandorojo
Copy link
Contributor

The following would also be nice:

  1. Wider toasts
  2. Unlimited lines of text.

@nandorojo
Copy link
Contributor

Related issue from burnt, my library which relies on SPIndicator: nandorojo/burnt#39

(PS thanks again for this great lib!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants