Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self referential call on "Set<?>.size()" results in Uncaught RangeError: Maximum call stack size exceeded #71

Open
34638a opened this issue Oct 9, 2023 · 4 comments

Comments

@34638a
Copy link

34638a commented Oct 9, 2023

Just dropping this off for later thorough investigation:
Issue appears to be repeatable. Issue arises in instances where a hashmap key set is retrieved and then the size of the set is requested.
Exact cause is yet to be determined as to why the minified has this result.
Full minified is attached.
j4ts.min.zip

Minified j4ts.js included below. Error case is found at j4ts.min.js?v=167416913297991951691696567159:1:305201

c.prototype.remove = function(t) { return !!this.__parent.containsKey(t) && (this.remove(t), !0) } , c.prototype.size = function() { return this.size() } ; var s, e = c; function c(t) { var e = s.call(this) || this; return e.__parent = t, e } function h(t, e) { this.outerIter = e, this.__parent = t } (t.AbstractMap$0 = e).__interfaces = ["java.util.Collection", "java.util.Set", "java.lang.Iterable"],

@lgrignon
Copy link
Collaborator

lgrignon commented Oct 9, 2023

Thanks for reporting @34638a

@34638a
Copy link
Author

34638a commented Oct 9, 2023

@lgrignon Asking a favour, if you can bump this on the weekend. I should should have a few hours spare to write a test case that demos this. Current codebase is under NDA so I can't generate a test java class from that sorry 😢. I'll try and get into the weeds over the summer break to contribute to the codebase if you accept pull requests.

@34638a
Copy link
Author

34638a commented Oct 9, 2023

@lgrignon Related question, is the project retired, archived or dead? If not would you be open to accepting new contributions to other packages as time permits. Given Kotlin is JS compatible I figured this is worth a ask seeing as you may have moved on.

@lgrignon
Copy link
Collaborator

@34638a that's a fair question. Most of the team is now working on other projects and therefore has only a few (if any) time to work on JSweet projects. Kotlin JS is indeed a great technology backed by Jetbrains but there are some significant differences, and IMHO there is still room for JSweet. The project is not dead but only PR from contributing users are now integrated.

If you want to file a PR, I can review and integrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants