Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Asterisk and QualifiedAsterisk in GROUP BY #16626

Open
3 tasks
lukaseder opened this issue May 2, 2024 · 0 comments
Open
3 tasks

Add support for Asterisk and QualifiedAsterisk in GROUP BY #16626

lukaseder opened this issue May 2, 2024 · 0 comments

Comments

@lukaseder
Copy link
Member

This is valid in ClickHouse:

create table t (i int, j int) engine = Log();
insert into t values (1, 1),(1, 1),(1, 2);

select *
from t
group by t.*, *;

Producing the expected:

|i  |j  |
|---|---|
|1  |2  |
|1  |1  |

I mean, why not? We can support this syntax and emulate it:

  • In the DSL API
  • In the QOM API
  • In the parser

This doesn't look like an incompatible change as Select::$groupBy returns UnmodifiableList<? extends GroupField> and GroupField can have new subtypes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant