Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential race condition with custom template parameters breaking defaults #857

Closed
kishan-character opened this issue May 15, 2024 · 1 comment · Fixed by #858
Closed
Assignees
Labels

Comments

@kishan-character
Copy link

I think the API might have recently broken...

I made this yesterday:
https://api.memegen.link/images/pigeon/Programmer_looking_at_code/Code_with_no_errors/Is_this_magic~q.png

if i try creating a new one now, it doesn't show the third caption:
https://api.memegen.link/images/pigeon/1/2/3~q.png

@jacebrowning jacebrowning self-assigned this May 15, 2024
@jacebrowning
Copy link
Owner

@kishan-character both of those links seem to be working now. I do think there is a race condition bug with custom template parameters conflicting with the existing YAML definition on the server so I'll keep this option.

@jacebrowning jacebrowning changed the title Missing Captions in new memes Potential race condition with custom template parameters breaking defaults May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants