Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] why add selector in dcr:name? #309

Open
dbu opened this issue Nov 10, 2015 · 2 comments
Open

[query] why add selector in dcr:name? #309

dbu opened this issue Nov 10, 2015 · 2 comments

Comments

@dbu
Copy link
Member

dbu commented Nov 10, 2015

as discovered with jackalope/jackalope#301, we seem to have a duplication of the selector name. why do we under some circumstances add the selector name to dcr:name in
https://github.com/jackalope/jackalope-doctrine-dbal/blob/master/src/Jackalope/Transport/DoctrineDBAL/Client.php#L2329 ? having it in dcr:selectorName would be enough (and actually simpler) for jackalope.

@dbu dbu changed the title why add selector in dcr:name? [query] why add selector in dcr:name? Nov 10, 2015
@lsmith77
Copy link
Member

I am pretty sure all of this was initially created with little understanding of things and just trying to emulate Jackrabbit as much as possible.

@dbu
Copy link
Member Author

dbu commented Nov 15, 2015

in this case, jackrabbit is not adding the selector in the column name, and only the order of the code in jackalope led to correct column names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants