Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests about multibyte utf-8 characters #85

Open
dbu opened this issue May 25, 2014 · 4 comments
Open

add tests about multibyte utf-8 characters #85

dbu opened this issue May 25, 2014 · 4 comments

Comments

@dbu
Copy link
Member

dbu commented May 25, 2014

we should test #84 - some of it in https://github.com/phpcr/phpcr-api-tests/ rather than just here.

we can also check if #55 or #65 can be relaxed now, they where about encoding problems.

/cc @OHB

@dantleech dantleech modified the milestone: 1.2 Nov 8, 2014
@dbu dbu removed this from the 1.2 milestone Jan 4, 2015
@alexander-schranz
Copy link
Contributor

Currently it seems the jackrabbit adapter does not support emoticons like 😢. They fail at current function:

$regex = '/[^\x{9}\x{a}\x{d}\x{20}-\x{D7FF}\x{E000}-\x{FFFD}]+/u';
return (preg_match($regex, $string, $matches) === 0);

Seems like it has todo with the linked PR here in #55. Do you know anything about emoticon support in jackrabbit, do we need to add any encode / decode functions to support such a thing.

/cc @lsmith77 @dbu

@dbu
Copy link
Member Author

dbu commented Oct 28, 2020

i did not look into this in a long time. jackalope-jackrabbit runs against the old-ish jackrabbit and we never took the effort to upgrade to oak. not sure if the latest jackrabbit builds would support it. afaik people did things like url-encode on their node names to handle this.

@alexander-schranz
Copy link
Contributor

@dbu For the name we are doing also url-encode/decode. But for the value we are not doing this thing. But if I understand you correctly the regex just avoids a jackrabbit call which would error and output a nicer error message, so it could be that newer jackrabbit version would not fail so we could remove this regex?

@dbu
Copy link
Member Author

dbu commented Oct 28, 2020

oh sorry, i misread what this is about. yes you could try what happens with a newer version of jackrabbit. if it works, then we can add some logic to only check this if jackrabbit is too old, or relax the check if more things work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants