Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectManager immediately methods and pending moves #156

Open
dbu opened this issue Mar 19, 2013 · 0 comments
Open

ObjectManager immediately methods and pending moves #156

dbu opened this issue Mar 19, 2013 · 0 comments
Labels

Comments

@dbu
Copy link
Member

dbu commented Mar 19, 2013

cloneFrom and workspace copy method (ObjectManager::copyNodeImmediately) both check if a node already exists at $destAbsPath by going through the session, which will trigger getFetchPath. with jackrabbit storage, we will create same-name siblings under /b if i do this

$session->move('/b', '/y');
$workspace->cloneFrom('ws', '/x', '/b', false);
$session->save();

what would be allowed to create the sibling would be

$session->move('/b', '/a');
$workspace->cloneFrom('ws', '/x', '/a', false);
$session->save();

but this will currently say you can't clone as there is a target. this should clone but then session save would create /a[1] or throw an exception.

this needs a general solution, some sort of raw exists check without applying getFetchPath.

follow up from #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant