Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor ObjectManager to have just one node array #157

Open
dbu opened this issue Mar 27, 2013 · 0 comments
Open

refactor ObjectManager to have just one node array #157

dbu opened this issue Mar 27, 2013 · 0 comments

Comments

@dbu
Copy link
Member

dbu commented Mar 27, 2013

the node array is currently nested, having one list per class (Node, Version, VersionHistory). this makes no sense as one tree element is always of exactly one of those types. instead of passing the class to build in, we should automatically determine that from the primary type of the node. right now if i getNode() a version node i would get a plain node for that which makes no sense.

also Version and VersionHistory are immutable, except through the VersionManager. we should enforce that to avoid wtf errors on save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant