Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🈷️ Svelte 5 Migration #42

Open
2 tasks done
oneezy opened this issue Apr 29, 2024 · 3 comments
Open
2 tasks done

🈷️ Svelte 5 Migration #42

oneezy opened this issue Apr 29, 2024 · 3 comments

Comments

@oneezy
Copy link

oneezy commented Apr 29, 2024

Double-Check

Clear description of the requested feature

With the recent Svelte Summit Spring talk, Svelte 5 has been moved into Release Candidate (RC) stage. How hard would it be to migrate Kitbook from 4 -> 5 ?

Suggested solution

Create breaking version change for Kitbook to use for Svelte v5

Alternative

No response

Additional context

No response

@jacob-8
Copy link
Owner

jacob-8 commented Apr 30, 2024

I'm very interested in making it work for Svelte 5. It would be trivial to make the variants, compositions, and documentation aspects work in Svelte 5. However, presently the Viewer aspect is blocked because it relies on Svelte internals. Read this comment to learn more. Since the internals are radically different now, I'm not even sure that what I'm doing in building up a component tree w/ associated elements is possible yet. Edit: not possible yet. However, since they officially support that svelte-devtools and @ignatiusmb is on the core team I'm confident that they will provide a way to accomplish this by the time 5.0 is released. Whatever ends up working for svelte-devtools will also work for Kitbook.

In the meantime, feel free to fork the project and release a Kitbook version w/o the Viewer. I'll update the docs to help people use it. I however, have projects in production that need to wait until 5.0, and I only like using Kitbook on real projects. I find it's not helpful for me to maintain a release that I'm not actually using myself as there's much higher likelihood of unnoticed bugs.

Follow this and this for updates.

@jacob-8
Copy link
Owner

jacob-8 commented Apr 30, 2024

Yes, this task depends on sveltejs/svelte#11389

@oneezy
Copy link
Author

oneezy commented May 1, 2024

thanks! yeah, i've also had my ui lib break because of svelte/internals. thanks for the links, will keep an eye out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants