Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to properly package link for local dev and also allow npm ci to still work? #3

Closed
jacob-8 opened this issue Nov 22, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@jacob-8
Copy link
Owner

jacob-8 commented Nov 22, 2021

When I push to the main branch with a new package version, I would GitHub actions to publish the new version, but I get this error upon the action running npm ci:

npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /home/runner/work/sveltefirets/sveltefirets/node_modules/sveltefirets/node_modules/sveltefirets/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/home/runner/work/sveltefirets/sveltefirets/node_modules/sveltefirets/node_modules/sveltefirets/package.json'
npm ERR! enoent This is related to npm not being able to find a file.

I know it has to do with how I'm referring to sveltefirets as "sveltefirets": "file:./package", in my package.json but don't know to fix. I have set it up this way so after my changes to my package I can run 'npm run package' and Vite automatically updates my demo app. Anyone know how to help me with this?

@jacob-8 jacob-8 added the help wanted Extra attention is needed label Nov 22, 2021
@wanghaisheng
Copy link

@jacob-8 why
"sveltefirets": "file:./package",

local dev

 cnpm install
× Install fail! Error: [sveltefirets@file:./package] resolved target D:\Download\audio-visual\saas\deploy\sveltefirets\package error: ENOENT: no such file or directory, lstat 'D:\Download\audio-visual\saas\deploy\sveltefirets\package'

@jacob-8
Copy link
Owner Author

jacob-8 commented Apr 7, 2022

@wanghaisheng For the moment I recommend copying sveltefirets manually as a folder into your SvelteKit project. There was a problem in Vite which caused SSR bugs when this library was installed. I believe Vite 2.9 fixed this issue (vitejs/vite#7154) but I haven't updated the library yet.

@jacob-8
Copy link
Owner Author

jacob-8 commented Aug 20, 2022

This issue has been fixed for awhile now.

@jacob-8 jacob-8 closed this as completed Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants