Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ASM to 9.2 #1206

Merged
merged 1 commit into from Jun 29, 2021
Merged

Upgrade ASM to 9.2 #1206

merged 1 commit into from Jun 29, 2021

Conversation

marchof
Copy link
Member

@marchof marchof commented Jun 28, 2021

No description provided.

@marchof marchof added the dependencies Pull requests that update a dependency file label Jun 28, 2021
@marchof marchof added this to Implementation in Current work items via automation Jun 28, 2021
@marchof marchof requested a review from Godin June 28, 2021 20:49
@marchof marchof self-assigned this Jun 28, 2021
Copy link
Contributor

@andrioli andrioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchof ASM 9.2 already have support for Java 18. You can update InstrSupport to use Opcodes.V18 directly

@marchof
Copy link
Member Author

marchof commented Jun 29, 2021

@andrioli We normally leave the code like it is so we can easily change it for experimental Java 19 support once we have the first Java 19 JDKs for testing.

Copy link
Member

@Godin Godin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchof as like I in #1094 (comment) you forgot to update version written in org.jacoco.build/licenses/asm-9.2.html 😉

Current work items automation moved this from Implementation to Review Jun 29, 2021
@Godin Godin changed the title Update to ASM 9.2 Upgrade ASM to 9.2 Jun 29, 2021
@Godin Godin merged commit 76e29ac into master Jun 29, 2021
Current work items automation moved this from Review to Done Jun 29, 2021
@Godin Godin deleted the asm-9.2 branch June 29, 2021 14:17
@Godin Godin added this to the 0.8.8 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core dependencies Pull requests that update a dependency file
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants