Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_settings_oauth is broken in rocket.chat 5.0 #168

Open
jadolg opened this issue Aug 9, 2022 · 4 comments
Open

test_settings_oauth is broken in rocket.chat 5.0 #168

jadolg opened this issue Aug 9, 2022 · 4 comments

Comments

@jadolg
Copy link
Owner

jadolg commented Aug 9, 2022

def test_settings_oauth(logged_rocket):

@jadolg
Copy link
Owner Author

jadolg commented Aug 9, 2022

@sistason could you please check this up? I'm unable to find good documentation about this and it started failing on the latest releases. You might have issues with this in your own codebase if you updated to 5.0 already.

@sistason
Copy link
Contributor

sistason commented Aug 9, 2022

I will check if I find something to fix this as soon as I can (next couple of days)

@sistason
Copy link
Contributor

I spend 2h looking at this mess, but did not find a solution.

I got the method.calls to work again, but the settings-endpoints for (oauth-)services (service.configurations + settings.oauth) do not return any services anymore, even complete, working oauth configs.

Will try to debug more later, I figure that we need to set some more fields in order for them to show up (https://github.com/RocketChat/Rocket.Chat/blob/develop/apps/meteor/app/api/server/v1/settings.ts#L68), but I'm a bit drained out from this right now -.-

@jadolg
Copy link
Owner Author

jadolg commented Aug 14, 2022

Maybe someone at https://open.rocket.chat/channel/python_rocketchat_api can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants