Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Stop testing with Node <v10; upgrade tchannel->4.x #463

Merged
merged 6 commits into from
Apr 28, 2021
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Apr 24, 2021

Which problem is this PR solving?

  • the CI no longer succeeds with Node 4
  • v10 is EOL in a few days

Short description of the changes

  • upgrade tchannel to 4.x to remove dependency on Node 0.10 (YAY!)
  • remove all Node versions earlier than v10; add versions 12, 14, 16
  • make Node v14 the primary
  • use official node/14-alpine base image for crossdock instead of hacky jaegertracing/xdock-node:docker-node-babel which has no source (see Replace docker-node-babel image that disappeared from Docker Hub #439)
    • turns out doing npm install is not that slow in Docker
  • clean-up GH actions and Make targets which had many unnecessary installs/uninstalls

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #463 (f912800) into master (4c739a2) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   98.67%   98.72%   +0.04%     
==========================================
  Files          50       50              
  Lines        2035     2035              
  Branches      383      383              
==========================================
+ Hits         2008     2009       +1     
+ Misses         27       26       -1     
Impacted Files Coverage Δ
src/reporters/remote_reporter.js 95.74% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c739a2...f912800. Read the comment docs.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title Stop testing with Node <v10, add latest versions Stop testing with Node <v10; add latest versions; upgrade tchannel->4.x Apr 25, 2021
@yurishkuro yurishkuro changed the title Stop testing with Node <v10; add latest versions; upgrade tchannel->4.x Stop testing with Node <v10; upgrade tchannel->4.x Apr 25, 2021
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit 6a6e3ea into master Apr 28, 2021
@yurishkuro yurishkuro deleted the remove-node-4 branch April 28, 2021 01:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant