Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Add sampling path for tracer sampler config (#532) #533

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

flysnoworg
Copy link
Contributor

Which problem is this PR solving?

Resolves #532

Short description of the changes

Signed-off-by: 飞雪无情 ls8707@gmail.com

Signed-off-by: 飞雪无情 <ls8707@gmail.com>
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #533 (f957c9e) into master (5a60f1e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #533   +/-   ##
=======================================
  Coverage   98.72%   98.73%           
=======================================
  Files          50       50           
  Lines        2044     2048    +4     
  Branches      386      387    +1     
=======================================
+ Hits         2018     2022    +4     
  Misses         26       26           
Impacted Files Coverage Δ
src/configuration.js 99.00% <100.00%> (+<0.01%) ⬆️
src/configuration_env.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a60f1e...f957c9e. Read the comment docs.

@yurishkuro yurishkuro merged commit 3454cd6 into jaegertracing:master Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot configure samplingPath for remote sampling in trace configuration
2 participants