Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: Upgrade redux-actions to 3.x #1260

Open
yurishkuro opened this issue Mar 12, 2023 · 11 comments · May be fixed by #1414
Open

[chore]: Upgrade redux-actions to 3.x #1260

yurishkuro opened this issue Mar 12, 2023 · 11 comments · May be fixed by #1414

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Mar 12, 2023

Requirement

Keep dependencies up to date

Problem

dependabot PR #1195 is failing with errors like Cannot find module 'redux-actions'.

Could be related to another PR #1169 that upgrades redux itself.

Proposal

No response

Open questions

No response

b4rsch pushed a commit to mayflower/jaeger-ui that referenced this issue Mar 17, 2023
…gend-off-by: Lars Iffland lars.iffland@mayflower.de
b4rsch pushed a commit to mayflower/jaeger-ui that referenced this issue Mar 17, 2023
…gned-off-by: Lars Iffland lars.iffland@mayflower.de
@ashutosh887
Copy link

@yurishkuro Is this resolved? I'm willing to work on this

@yurishkuro
Copy link
Member Author

I don't think it's resolved, it's probably a part of more complicated upgrade process that
@mszabo-wikia was working on in #1261 and before that.

@mszabo-wikia
Copy link
Contributor

Yup that's right, I haven't touched redux or related deps in that work. If someone wants to have a go at this, I think it's possible—it shouldn't depend on the antd upgrade or other pending work.

@ashutosh887
Copy link

@mszabo-wikia @yurishkuro
Should I work on this?

@ashutosh887
Copy link

Please let me know what all need to be updated

@M00nNight
Copy link

@yurishkuro Hello sir I just new to this so try to contribute in this repository I just figure out the redux-action version
so i just manually update redux-action version.
which in the file path "https://github.com/jaegertracing/jaeger-ui/blob/main/packages/jaeger-ui/package.json"
line no.64 [@types/redux-actions": "2.2.1"] to this [@types/redux-actions": "^3.0.0"]

if this solution not right please give feedback 🙏

@yurishkuro
Copy link
Member Author

@M00nNight and do the tests pass after you make that change?

@prathamesh-mutkure
Copy link
Contributor

prathamesh-mutkure commented Aug 10, 2023

@yurishkuro, I'd like to work on this, can you assign me this?

The v3 seems to have introduced breaking changes

@yurishkuro
Copy link
Member Author

feel free to work on it, but we do not assign issues. https://github.com/jaegertracing/jaeger/blob/main/CONTRIBUTING_GUIDELINES.md#assigning-issues

@prathamesh-mutkure
Copy link
Contributor

Sure, will submit a PR soon

@prathamesh-mutkure
Copy link
Contributor

Hey @yurishkuro, there's actually some problem with redux-actions@3.0.0 + jest

Jest is unable to find the redux-actions package, and this issue seems to be unresolved for now

Should we wait for a solution or we can upgrade to v2.6.5 for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants