New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore]: Upgrade redux-actions to 3.x #1260
Comments
…gend-off-by: Lars Iffland lars.iffland@mayflower.de
…gned-off-by: Lars Iffland lars.iffland@mayflower.de
@yurishkuro Is this resolved? I'm willing to work on this |
I don't think it's resolved, it's probably a part of more complicated upgrade process that |
Yup that's right, I haven't touched redux or related deps in that work. If someone wants to have a go at this, I think it's possible—it shouldn't depend on the antd upgrade or other pending work. |
@mszabo-wikia @yurishkuro |
Please let me know what all need to be updated |
@yurishkuro Hello sir I just new to this so try to contribute in this repository I just figure out the redux-action version if this solution not right please give feedback 🙏 |
@M00nNight and do the tests pass after you make that change? |
@yurishkuro, I'd like to work on this, can you assign me this? The v3 seems to have introduced breaking changes |
feel free to work on it, but we do not assign issues. https://github.com/jaegertracing/jaeger/blob/main/CONTRIBUTING_GUIDELINES.md#assigning-issues |
Sure, will submit a PR soon |
Hey @yurishkuro, there's actually some problem with Jest is unable to find the redux-actions package, and this issue seems to be unresolved for now Should we wait for a solution or we can upgrade to |
Requirement
Keep dependencies up to date
Problem
dependabot PR #1195 is failing with errors like
Cannot find module 'redux-actions'
.Could be related to another PR #1169 that upgrades redux itself.
Proposal
No response
Open questions
No response
The text was updated successfully, but these errors were encountered: