Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API not up-to-date? #19

Open
rowild opened this issue May 18, 2020 · 1 comment
Open

API not up-to-date? #19

rowild opened this issue May 18, 2020 · 1 comment

Comments

@rowild
Copy link

rowild commented May 18, 2020

It seems that the hooks api of htmlWebpackPlugin changed.

Currently, this plugin throws an error:
Error: The expected HtmlWebpackPlugin hook was not found! Ensure HtmlWebpackPlugin is installed and was initialized before this plugin.

This is the case, because the plugin checks against
if (!compilation.hooks.htmlWebpackPluginAlterAssetTags) {

checking the hooks that htmlWebpackPlugin provides:
https://github.com/jantimon/html-webpack-plugin#events

such a hook is not offered and therefore not available.

However, changing to what seems to be the closest candidate: alterAssetTagGroups also dow not work.

It seems there is a drop-in-replacement for this plugin, https://github.com/swimmadude66/html-webpack-skip-assets-plugin, but it would be great anyway, if there was a chance to update this plugin or mark it as deprecated with a note up to which version of htmlWebpackPlugin this was working.

Thank you!

@rpb138
Copy link

rpb138 commented Jul 17, 2020

James, fix your shit!

@rowild thank you for putting the replacement link in your comment! Saved me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants