Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor http resolver into separate npm package #428

Open
jamesramsay opened this issue Jan 7, 2018 · 0 comments
Open

Refactor http resolver into separate npm package #428

jamesramsay opened this issue Jan 7, 2018 · 0 comments

Comments

@jamesramsay
Copy link
Owner

The HTTP resolver has heavier dependencies (e.g. got) than the rest of hercule. For applications using hercule in the browser, the ability BYO HTTP library is appealing so that I can use reuse axios or some other heavier library I may already be using, or roll my own tiny lightweight solution.

Splitting out a new a new package could easily increase the maintenance burden of this project and make it hard for new resolvers to be contributed. Using a monorepo may be a solution to this (see http://alexwheeler.io/ruby/git/2017/09/16/monorepos.html).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant