Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHCR docker container? #17

Closed
1 task done
aaomidi opened this issue Jan 22, 2024 · 12 comments · Fixed by #24
Closed
1 task done

GHCR docker container? #17

aaomidi opened this issue Jan 22, 2024 · 12 comments · Fixed by #24
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed waiting-for-feedback Waiting on feedback

Comments

@aaomidi
Copy link
Contributor

aaomidi commented Jan 22, 2024

Have you read the Important information text above

  • Yes i did

Current behavior

Container is only shared on docker hub.

Desired behavior

GitHub Container Registry is also a place to get the containers from

Links to screenshots

No response

To Reproduce

N/A

Software setup

N/A

Hardware setup

N/A

Additional context

GHCR has a lot more permissive rate limiting.

@jammsen
Copy link
Owner

jammsen commented Jan 22, 2024

Hello @aaomidi
IF i understand you correctly, you want me to NOT host on Docker-Hub or to ALSO host on Github Container Registry?
Could you please clarify what you need and want me to do? This issue is little sparse.
Could you please clarify what you mean by "GHCR has a lot more permissive rate limiting."? Not sure i understand.

My motherlanguage is German, sorry if my english isnt good enough to undertand this slim-describen issue.

@jammsen jammsen self-assigned this Jan 22, 2024
@jammsen jammsen added the issue-unclear Issue unclear label Jan 22, 2024
@jseiser
Copy link

jseiser commented Jan 22, 2024

Could you please clarify what you mean by "GHCR has a lot more permissive rate limiting."? Not sure i understand.

Dockerhub has rate limiting in place: https://docs.docker.com/docker-hub/download-rate-limit/

I dont believe its something you, as the person creating the image should worry about. Host wherever you feel appropriate

@jammsen
Copy link
Owner

jammsen commented Jan 22, 2024

Hey @jseiser - Oh he means the Docker Image Pull Limit, now i understand.

Hey @aaomidi - Well if you hit your limit by pulling 200 images with an user account, im not sure what i can do about that 😄 but if you ask me if i could add GHCR as a 2nd source repo, i would have to look into that.

@aaomidi
Copy link
Contributor Author

aaomidi commented Jan 22, 2024

Oh yeah I was asking for GHCR in addition to docker hub. I can even make the PR for this, it's pretty simple since you just add another tag to the image and push it to GHCR.

@jammsen
Copy link
Owner

jammsen commented Jan 22, 2024

Sure do a PR and i will look into that

@jammsen jammsen reopened this Jan 23, 2024
@jammsen jammsen added enhancement New feature or request help wanted Extra attention is needed waiting-for-feedback Waiting on feedback and removed issue-unclear Issue unclear labels Jan 23, 2024
@jammsen
Copy link
Owner

jammsen commented Jan 23, 2024

Hey @aaomidi that PR looked good to me so i merged it, the documentation didnt really mention to setup permissions before hand so i had to figure out that the hard way. Ive dont that and now its on GHCR also.

But its weird,it looks like its 2 architectures somehow?!
image

Would this be compatible with #23 also?

jammsen added a commit that referenced this issue Jan 23, 2024
jammsen added a commit that referenced this issue Jan 23, 2024
jammsen added a commit that referenced this issue Jan 23, 2024
jammsen added a commit that referenced this issue Jan 23, 2024
jammsen added a commit that referenced this issue Jan 23, 2024
jammsen added a commit that referenced this issue Jan 23, 2024
@jammsen
Copy link
Owner

jammsen commented Jan 23, 2024

Hey @aaomidi that PR looked good to me so i merged it, the documentation didnt really mention to setup permissions before hand so i had to figure out that the hard way. Ive dont that and now its on GHCR also.

But its weird,it looks like its 2 architectures somehow?! image

Would this be compatible with #23 also?

I made it now compatible with #23

@aaomidi But my question remains un-answered, why are there no 2 architectures with is one of them unknown??!?

@aaomidi
Copy link
Contributor Author

aaomidi commented Jan 23, 2024

Thank you so much for figuring out the few things there.

I believe what's happening is provenance attestations: https://docs.docker.com/build/attestations/slsa-provenance/

I remember running into this problem before. Seems like it is a known issue with GHCR: https://github.com/orgs/community/discussions/45969

I remember just working around it by switching to docker/build-push-action@v3

@jammsen
Copy link
Owner

jammsen commented Jan 23, 2024

Thank you so much for figuring out the few things there.

No problem, happy to help

I believe what's happening is provenance attestations: https://docs.docker.com/build/attestations/slsa-provenance/

I remember running into this problem before. Seems like it is a known issue with GHCR: https://github.com/orgs/community/discussions/45969

I remember just working around it by switching to docker/build-push-action@v3

ehh yeah .... 😕

@aaomidi
Copy link
Contributor Author

aaomidi commented Jan 23, 2024

Oh, some potentially good news: docker/build-push-action#900

@jammsen
Copy link
Owner

jammsen commented Jan 23, 2024

Very nice!

@jammsen
Copy link
Owner

jammsen commented Jan 25, 2024

Can this issue be closed?

If you like this project, please give this repo and the docker-hub-repo a Star.

@jammsen jammsen closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed waiting-for-feedback Waiting on feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants