Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent inclusion of timestamps in logs #3004

Open
strk opened this issue Feb 4, 2023 · 3 comments
Open

Inconsistent inclusion of timestamps in logs #3004

strk opened this issue Feb 4, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@strk
Copy link

strk commented Feb 4, 2023

Logs of client connections include timestamp while logs of servers connections (to directory) do not.
This inconsistency result in either duplication of timestamp (if you add them externally) or lack of timestamp (if you don't).

See #3001

I'd suggest making it an option to include them, or never include them (relying on external tools to timestamp them).

@strk strk added the bug Something isn't working label Feb 4, 2023
@pljones
Copy link
Collaborator

pljones commented Feb 4, 2023

Jamulus doesn't write a log of server connections to a directory.

We can remove the log of client connections to a server and have them treated the same way, though. It would simplify Jamulus.

@ann0see ann0see added this to Triage in Tracking (old) via automation Feb 4, 2023
@strk
Copy link
Author

strk commented Feb 5, 2023

Yeah, I would simplify. I was actually surprised I couldn't run ONLY a directory w/out an associated server. If it was possible I'd have less problems with this logging inconsistency :)

@pljones
Copy link
Collaborator

pljones commented Feb 6, 2023

I was actually surprised I couldn't run ONLY a directory w/out an associated server.

Currently the minimum client count is validated to be more than zero and less than (IIRC) 150. I think we did take a look at making zero possible but it would need additional work to just allowing it and setting the client count to 1 does discourage use as a general use server. That's how all the built-in directories except Any Genre 1 work. (And that's because AG1 directory is the default server.)

@pljones pljones removed this from Triage in Tracking (old) Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Triage
Development

No branches or pull requests

2 participants