-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Jamulus.pro relies on git and Linux #3087
Comments
... this means we need to find a way to generate an unique per build/release increasing number. I suggested two ways:
|
Via the Qt qmake Variables manual page, Google's explanation for the value. It's important that any build of
... which means making the version number differently ... potentially leading to non-sequential numbering. I wonder if The problem is:
which in seconds-from-epoch is
I'm hoping the end of the world hasn't happened by then.
You'd need padding. 3.1.99 is less than 3.11.9, so just stripping dots wouldn't do ( |
So, requirements:
|
If we presume this means a build performed by the Github build actions, then the value could be edited in place, committed to git and then built. That would then meet requirements 2, 4, 5 and 6. All we'd need to do is start the number at
being the tricky bit. |
Actually, not 4. We'd still have no way to know if there were local changes without git. So we're back relying on git. I think I'd prefer the number to be zero for any release not built by the Github build chain - set to zero in |
I'm going to put this into Triage. It needs more thought. I don't know enough about Github automation or the Qt build process, really. |
Describe the bug
When building the Android version of Jamulus,
Jamulus.pro
currently relies on the git commit count to generate theANDROID_VERSION_CODE
.Currently, the
| wc -l
used to generate the count limits the build to running on a Linux-based machine. This command fails on Windows (hence #3083).The
git log --oneline
introduces a dependency ongit
being installedgit
repo rather than the source tarballTo Reproduce
where
5471
is the result ofgit log --oneline | wc -l
.git log --oneline
will fail, causing theqmake
to error outwc -l
command will fail, causing theqmake
to error outExpected behavior
The
ANDROID_VERSION_CODE
is used by Google Play Store to distinguish versions of an application. Each version should have a higher number than any it is intended to supercede, hence:From #3083 (comment)
That is, any environment Android Qt build environment should be able to build Jamulus, either for Google Play Store or not, from the source tarball.
The text was updated successfully, but these errors were encountered: