New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BadRequestException is not marked abstract #757

Open

dkarlovi opened this issue Sep 29, 2023 · 0 comments

Labels

bug

Contributor

dkarlovi commented Sep 29, 2023

Jane version(s) affected: 7.5.3

Description
BadRequestException is extended by specific exceptions, it should be abstract.

How to reproduce
Have an API generate response 400, you get BadRequestException and a specific exception extending it.

Possible Solution
Make it abstract or skip generating it.

Additional context

This is a problem when you're running a strict CS fixer on your code which makes all the non-abstract classes final.

dkarlovi added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment