Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basedialog addition of fragments to backstack can be problematic #58

Open
abhi472 opened this issue Feb 16, 2018 · 0 comments
Open

basedialog addition of fragments to backstack can be problematic #58

abhi472 opened this issue Feb 16, 2018 · 0 comments

Comments

@abhi472
Copy link
Contributor

abhi472 commented Feb 16, 2018

in basedialog where we are doing the fragment transaction, fragments are added to backstack
although it does seem harmless but in the cases where there is a repeated call to a same dialog(for eg. a network error dialog with retry option), same dialog is added to the backstack and even after transaction.remove() is applied the same dialog is reappearing.
By simply removing addtobackstack(null) we can save us from this problem,
anyhow i don't understand why do we need to retain a fragment after back press if we are handling removing similar dialogs anyway.
I solved my problem by removing addToBackStack(null)
i think this should also be applied in this repo too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant