Missings typings property in package.json in beta

[SimonSchick]

Expected behaviour

Types load correctly.

Current behaviour

Types do not load.

Environment

Latest TS version on node 10.12.

Config

import HTMLPlugin from 'html-webpack-plugin';

Relevant Links

https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

[SimonSchick]

Actually, the typings you are shipping seem to be incorrect in general as you are not exporting the class instance correctly.

[SimonSchick]

See https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/html-webpack-plugin/index.d.ts

[jantimon]

Could you please be a little bit more concrete?

[SimonSchick]

Compare https://github.com/jantimon/html-webpack-plugin/blob/master/typings.d.ts with https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/html-webpack-plugin/index.d.ts

The typings shipped with this package are mostly useless without the class export.

[hornta]

Or we can rename typings.d.ts to index.d.ts according to https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

[wingrunr21]

Adding a types property is advised even if it is named index.d.ts

[jantimon]

But we don’t export the typings - we use the typescript salsa feature jsdocs as typings.

The typings.d.ts is just an internal helper for the html-webpack-plugin.

However the typescript team is working on generating definition files from salsa files.

Once that works we will provide a typing file which we will link from the package.json to the type file

[wingrunr21]

@jantimon does that mean you aren't interested in merging #1132? I opened that precisely so that this project would export typings that are usable in TS based webpack configs.

[jantimon]

The main idea was to prevent bugs by using types from webpack.

If the changes you did on #1132 are enough to provide external typings then I am happy to make them public as types