introduce support for <base> (matching <title> and <meta>)

[atstp]

this will let users inject a base tag in a manner similar to the current implementation for title and meta.

It also includes docs along with two new tests (adds a base tag with attributes and adds a base tag short syntax) for the introduced features.

I didn't see a contributing guide, so if you have any other questions or requests just let me know.

[jantimon]

Why wouldn’t that be possible with the webpack publicPath option or a custom template?

[atstp]

base and publicPath

It's not possible with publicPath because base, aside from a small scenario, serves a different role. They are similar in that they both can affect how paths are interpreted, but that's about it. How they do it, what they can affect, and the context they work in are all different. Here's a few significant differences:

• Webpack's publicPath sets a prefix string only for assets that webpack manages.
• The base tag's href determines how all relative urls are resolved, including relative hyperlinks.
• There's also base's target attribute. If it's set, it specifies the default browsing context when navigating via links and forms (e.g. setting target=_blank in base will cause links to open in a new tab).

first-class support vs. templates vs. plugins

It's is possible with templates, or plugins for that matter. But, implementing it in html-webpack-plugin was cleaner and less obtuse than the alternatives.

Here's our use-case if you're curious:

• We didn't need templates for anything else
  • Introducing a file just to get a single line seemed heavy handed
• We use base (and sometimes its target) conditionally, depending on where we're deploying, thanks to some legacy requirements.
  • so if we did add a template it would need a bit of logic and new template plus template-logic seemed even less appealing
  • it would be nice to as much build configuration in webpack.config.js. moving decision making to templates isn't ideal.
• We're doing it with a plugin (for now)
  • it seems goofy to hook into webpack's compilation just to add a line that doesn't involve any assets being compiled

On the user side, for each alternative above, the implementation was about as long and significantly more obtuse than implementing the same thing in html-webpack-plugin.

Alternatives aside, specifying base would fit well as an option to html-webpack-plugin in its own right. title, meta, and base are unique HTML elements: They're the only standardized head elements that are configured with a few short strings and don't load external assets. html-webpack-plugin already supports the first two (for obvious reasons); supporting base would make sense for the same reasons, and would make html-webpack-plugin's behavior consistent.

Hope it helps, and if you've got any further questions, let me know.

[jantimon]

The code you provide looks awesome - my only concern is if that’s a common requirement or an edge case 🤔

Do you know if base target blank is vulnerable to window opener attacks?

[jantimon]

Right now this feature would not work if inject is false - I think that should be okay.. or do you think we should also add it to the default template?

[atstp]

Yeah, I understand your caution: the real cost comes from maintenance.

For what it's worth, you're welcome to ping me here on github if this needs attention in the future. I'll be happy to write up a patch or field questions (i'll be doing that no matter what, this PR just affects where).

It's your project though, so we'll work with whatever your final decision is.

Either way, thanks for actively maintaining this project.

[atstp]

I agree. The inject: false behavior seems fine as is.