Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html-minifier uses uglify-js what doesn't support ecma6+ #1262

Closed
alexander-akait opened this issue Aug 12, 2019 · 4 comments
Closed

html-minifier uses uglify-js what doesn't support ecma6+ #1262

alexander-akait opened this issue Aug 12, 2019 · 4 comments

Comments

@alexander-akait
Copy link
Collaborator

Expected behaviour

Minify js in ecma6+

Current behaviour

webpack-contrib/terser-webpack-plugin#114

Environment

No matter

Config

No matter

Relevant Links

https://github.com/kangax/html-minifier/blob/gh-pages/package.json#L63

Additional context

honestly, I don’t even know how best to fix it, maybe we’ll create our own module for minification, but it may be overhead, maybe we should raise this issue html-minifier, any ideas?

@jantimon
Copy link
Owner

jantimon commented Aug 13, 2019

@evilebottnawi I asked the html-minifier maintainers to upgrade to terser - what exactly is happening right now? Is es6 code just ignored or is it causing errors?

@alexander-akait
Copy link
Collaborator Author

@jantimon error, whaen people use es6 code

@alexander-akait
Copy link
Collaborator Author

@jantimon i have idea, maybe i can create hook inside terser-webpack-plugin and you will use hook for js minification, it is allow to use do better integration with terser?

@jantimon
Copy link
Owner

html-webpack-plugin 4.0.0-beta.11 switched to html-minifier-terser

@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants