Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix querystring encoding #1386

Merged
merged 1 commit into from Apr 1, 2020
Merged

fix: Fix querystring encoding #1386

merged 1 commit into from Apr 1, 2020

Conversation

jantimon
Copy link
Owner

@jantimon jantimon commented Apr 1, 2020

fix #1355

fo:demonstration-path/very fancy+name.js?path=/home?value=abc&value=def#zzz
   ^            ^    ^    ^     ^    ^  ^    ^^    ^     ^   ^     ^   ^
   |            |    |    |     |    |  |    ||    |     |   |     |   |
encoded         |    |    encoded    |  |    ||    |     |   |     |   |
               ignored              ignored  ignored     ignored   ignored              

Copy link
Contributor

@zbigg zbigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good too me.

filePath.indexOf('?');

If it would be me, i would use lastIndexOf but after few thoughts, cut-off on first ? looks like more currect and robust.

@jantimon jantimon merged commit 4f48a39 into master Apr 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
@jantimon jantimon deleted the fix/querystring-encoding branch October 13, 2020 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js file is not injected, but css file is injected to the template with 4.0.0-beta.11 version.
2 participants