Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass all Node.js globals to templates #1796

Merged
merged 2 commits into from Jun 9, 2023
Merged

fix: pass all Node.js globals to templates #1796

merged 2 commits into from Jun 9, 2023

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Jun 9, 2023 •
edited

fixes #1747

Changed from requrie("url") because -

v10.0.0 The class is now available on the global object.

and our minimum supported node.js version is 10, so we don't need this workaround for old versions

@alexander-akait alexander-akait merged commit f269fc0 into main Jun 9, 2023
10 checks passed
@alexander-akait alexander-akait deleted the issue-1747 branch June 9, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Globals TextEncoder and TextDecoder are not accessible from inside template code
1 participant
@alexander-akait