feat: add @rspack/core as an optional peer dependency #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
Dec 19, 2023
|
Thanks! |
chenjiahan
added a commit
to rspack-contrib/html-rspack-plugin
that referenced
this pull request
Dec 22, 2023
* fix: reemit favicon in serve/watch mode (jantimon#1804) * refactor: use logger to avoid pulling logs in output (jantimon#1805) * refactor: avoid extra file (jantimon#1806) * refactor: code (jantimon#1807) * docs: improve (jantimon#1808) * fix: avoid have undefined `type` for script tags (jantimon#1809) * refactor: fix regression after refactor and testing (jantimon#1810) * fix: reemit assets from loaders (jantimon#1811) * test: case for watch/serve and reemitting assets (jantimon#1812) * docs: add js-entry-webpack-plugin (jantimon#1732) * chore(release): 5.5.4 * docs: add html-webpack-inject-attributes-plugin to readme (jantimon#1787) * feat: Added support `type=systemjs-module` via the `scriptLoading` option (jantimon#1822) * fix: memoy leak (jantimon#1836) * feat: add `@rspack/core` as an optional peer dependency (jantimon#1829) * chore(release): 5.6.0 --------- Co-authored-by: Alexander Akait <4567934+alexander-akait@users.noreply.github.com> Co-authored-by: liam <lawler61@163.com> Co-authored-by: alexander.akait <sheo13666q@gmail.com> Co-authored-by: Yuwen Duan <dyw934854565@sina.com> Co-authored-by: 坏人日记 <badry.lin@gmail.com> Co-authored-by: Joe Boyle <jboyle617@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Rspack is a fast Rust-based web bundler and it is compatible with the architecture and ecosystem of webpack.
The
html-webpack-plugincan be used with Rspack, but users will get a peer dependency warning:WARN Issues with peer dependencies found . └─┬ html-webpack-plugin 5.5.3 └── ✕ missing peer webpack@^5.20.0Description
This PR adds
@rspack/coreas an optional peer dependency, and make webpack as an optional peer dependency too.Related issues
@rspack/coreto the peer dependencies of html-webpack-plugin and react-refresh-webpack-plugin web-infra-dev/rspack#4537