Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile-friendly default #897

Closed
wants to merge 1 commit into from

Conversation

jakearchibald
Copy link

I guess the default template is deliberately bare, but it feels like mobile-friendly should be the default these days.

I guess the default template is deliberately bare, but it feels like mobile-friendly should be the default these days.
@NekR
Copy link
Contributor

NekR commented Mar 9, 2018

Unfortunately I know zillion of folks who doesn't care about mobile and just ship desktop version to it. So this at least would need to have option to not include the viewport tag (also, yeah, many people don't write HTML manually, so won't just use custom template to remove the viewport ¯_(ツ)_/¯). Not sure if those 2 groups of people "overlap" though.

@jakearchibald
Copy link
Author

jakearchibald commented Mar 9, 2018

Would this harm developers who don't care about mobile?

@NekR
Copy link
Contributor

NekR commented Mar 9, 2018

Not "don't care", but rather "let people on mobile use desktop version and zoom in an out, because we don't have money and time for mobile dev and who cares anyway when there is React Native" lol.

That minimum zoom value won't allow users to scale down 900px wide website, right?

@jakearchibald
Copy link
Author

That minimum zoom value won't allow users to scale down 900px wide website, right?

Correct. If this is still prevalent enough that creating a custom template is too high a bar, then I guess there could be a simpler opt-out.

@jantimon
Copy link
Owner

jantimon commented Mar 9, 2018

Some background info:
https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag

We also allow to inject viewports into the html file.
So it would be quite easy to have a plugin similar to https://github.com/GoogleChromeLabs/preload-webpack-plugin which would add the viewport tag.

We could also provide multiple base templates.

@jantimon jantimon mentioned this pull request Mar 20, 2018
@jantimon
Copy link
Owner

jantimon commented Mar 20, 2018

I would like to close it as this could be solved here #419 (comment)
Please let me know if you see any issues here.

@jantimon jantimon closed this Mar 20, 2018
@lock
Copy link

lock bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
jantimon added a commit that referenced this pull request Jul 6, 2018
BREAKING CHANGE: The default template has now a predefined viewport meta tag

fix #897, fix #978
jantimon added a commit that referenced this pull request Jul 10, 2018
BREAKING CHANGE: The default template has now a predefined viewport meta tag

fix #897, fix #978
jantimon added a commit that referenced this pull request Jul 10, 2018
BREAKING CHANGE: The default template has now a predefined viewport meta tag

fix #897, fix #978
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants