Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why is meta viewport is not included by default? #978

Closed
bchenSyd opened this issue Jun 14, 2018 · 3 comments
Closed

why is meta viewport is not included by default? #978

bchenSyd opened this issue Jun 14, 2018 · 3 comments

Comments

@bchenSyd
Copy link

I believe this questions has been asked before and the solution been give was to use custom template.

My understanding is that ppl don't want to create a separate index.html file and that's why we are here; Is there any consideration why viewport meta is not included by default?

@jantimon
Copy link
Owner

Please take a look at #897 and #906.

Basically you can use it as follows:

new HtmlWebpackPlugin({
   meta: {viewport: 'width=device-width, initial-scale=1, shrink-to-fit=no'}
});

Also there is no simple on off viewport but you can configure different options.
You can find a good list here:

https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag

Is there a standard for a good default?

@bchenSyd
Copy link
Author

bchenSyd commented Jun 14, 2018

i think the example you gave was good enough.

Most people don't care about the nuance of different options, and if they do, they should use custom template.
make sense?

jantimon added a commit that referenced this issue Jul 6, 2018
BREAKING CHANGE: The default template has now a predefined viewport meta tag

fix #897, fix #978
jantimon added a commit that referenced this issue Jul 10, 2018
BREAKING CHANGE: The default template has now a predefined viewport meta tag

fix #897, fix #978
jantimon added a commit that referenced this issue Jul 10, 2018
BREAKING CHANGE: The default template has now a predefined viewport meta tag

fix #897, fix #978
@lock
Copy link

lock bot commented Aug 9, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants