Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inflect/__init__.py::inflect.engine.compare test fails with pydantic-core >= 2.12 #204

Closed
jhatler opened this issue Dec 24, 2023 · 1 comment
Closed

inflect/__init__.py::inflect.engine.compare test fails with pydantic-core >= 2.12 #204

jhatler opened this issue Dec 24, 2023 · 1 comment

Comments

@jhatler
Copy link

jhatler commented Dec 24, 2023

The below PR on pydantic-core introduced a change to the validation error messages which breaks the inflect/init.py::inflect.engine.compare test.

pydantic/pydantic-core#1050

The test breaks because the error message defined at the below line is plural when the number "1" is used, which is grammatically incorrect.

inflect/inflect/__init__.py

Line 2469 in eff29a4

...at least 1 characters...

jhatler added a commit to jhatler/inflect that referenced this issue Dec 24, 2023
@jhatler
fix: compare validation now expects singular noun
f6177e1 
On pydantic-code >= 2.12, the validation error messages use the singular
of the word "character" when the number 1 is specified in a condition.
This breaks the engine.compare validation, which expected the plural.

Refs: jaraco#204
Signed-off-by: Jaremy Hatler <hatler.jaremy@gmail.com>
This was referenced Dec 24, 2023
Open
Closed
algitbot pushed a commit to alpinelinux/aports that referenced this issue Mar 21, 2024
@ncopa
community/py3-inflect: backport fix for test
a72a878 
ref: jaraco/inflect#204
@jaraco
Copy link
Owner

jaraco commented Mar 31, 2024

Thanks for the report and the pull request. I addressed the issue in 5ef0bab.

@jaraco jaraco closed this as completed Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaraco @jhatler