Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws a missleading error a the module fails to load #3

Open
hockeytim11 opened this issue Feb 26, 2016 · 2 comments
Open

Throws a missleading error a the module fails to load #3

hockeytim11 opened this issue Feb 26, 2016 · 2 comments

Comments

@hockeytim11
Copy link

Currently this module swallows all errors when the trying to load a module.

I suggest adding this to the catch block:

if(ex.code !== 'MODULE_NOT_FOUND') {
   throw ex;  
}

This allows the module to still search up the stack, but if it finds a module and has a legitimate error loading the module you can still catch that error.

@JimtotheB
Copy link

This is biting me right now as well.

@toporelo
Copy link

toporelo commented Jul 15, 2018

IhavebeenzipCodemapofmyfavoriteisthebest5MsIthesame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@hockeytim11 @JimtotheB @toporelo and others