Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context/tags/extra should be pulled from state not window #2

Open
sitch opened this issue May 7, 2018 · 1 comment
Open

context/tags/extra should be pulled from state not window #2

sitch opened this issue May 7, 2018 · 1 comment

Comments

@sitch
Copy link

sitch commented May 7, 2018

Take a look at the improvements section in https://github.com/captbaritone/raven-for-redux

Ideally we should construct and set context/tags/extra from state on each potential error, that way web apps that allow multiple uses don't have to restart their app. Happy to fork/PR this
@sitch
Copy link
Author

sitch commented May 7, 2018

Also an easy fix for this is just to hook into onStateChange within dva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sitch