Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next release with rollup plugin async support #532

Closed
jmarceli opened this issue Mar 3, 2020 · 6 comments
Closed

Next release with rollup plugin async support #532

jmarceli opened this issue Mar 3, 2020 · 6 comments
Labels
solution: duplicate This issue or pull request already exists

Comments

@jmarceli
Copy link

jmarceli commented Mar 3, 2020

Current Behavior

Currently, (tsdx 0.12.3) it is not possible to use rollup plugins with async functions e.g. @svgr/rollup

Expected behavior

It should be possible

Suggested solution(s)

It is probably already fixed on the master branch thanks to rollup-plugin-typescript2 update to 0.26 we just need next release.

Are there any plans for the release anytime soon?

@agilgur5
Copy link
Collaborator

agilgur5 commented Mar 3, 2020

Related to #512

Yep I fixed the root cause of #294 with #506 , ezolenko/rollup-plugin-typescript2#203, and puleos/object-hash#90

Unfortunately, while I worked quite hard on getting the whole chain of dependencies fixed, I have 0 permissions to do anything like issue triage, merge PRs, or make releases, so it's still not released in TSDX....
Jared hasn't been doing it himself and hasn't added more maintainers so I'm strongly considering forking at this point

@jmarceli
Copy link
Author

jmarceli commented Mar 3, 2020

Hi, thanks for letting me know. Maybe @jaredpalmer could add you or anyone else interested in collaboration as a maintainer. Without your update, it is not possible to use some (probably multiple) rollup plugins with async functions.

@agilgur5
Copy link
Collaborator

agilgur5 commented Mar 3, 2020

Unfortunately, there have been multiple repeat issues / comments on things that already have PRs out and haven't been merged or that have already been merged and haven't been released (see #512 ).

This isn't the only thing that's bottlenecked and it's not an isolated incident 😔

@jmarceli
Copy link
Author

jmarceli commented Mar 4, 2020

Thanks for letting me know. I will probably try to eject from tsdx but as you have mentioned this might be a good time for forking

@agilgur5 agilgur5 added the solution: duplicate This issue or pull request already exists label Mar 9, 2020
@agilgur5
Copy link
Collaborator

agilgur5 commented Mar 9, 2020

I emailed Jared and have been added as a collaborator to the repo, so I'll close this out as a duplicate. I still don't have permissions to publish on NPM unfortunately though, but hopefully I'll get those soon.

@agilgur5 agilgur5 closed this as completed Mar 9, 2020
@agilgur5
Copy link
Collaborator

Was given publishing rights yesterday and just released v0.13.0. Please refer to #512 (comment) with any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants