From eb41bbe3cea1075d4ef44cbcfec4151ab838dc2b Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Sat, 11 Apr 2020 13:38:36 -0400 Subject: [PATCH] (fix): @types/jest should be a dep, not a devDep - per bug report, this caused an issue where the @types/jest that was installed via `create` would have a version mismatch with the jest and jest-related deps used by TSDX - and ts-jest's installation instructions also say to install @types/jest, so it's kind of a peerDep to it - also move @types/shelljs to devDeps as it's not needed for usage of the CLI, it's only used internally --- package.json | 4 ++-- src/templates/basic.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index e2fd407d..f07ab996 100644 --- a/package.json +++ b/package.json @@ -49,7 +49,7 @@ "@rollup/plugin-json": "^4.0.0", "@rollup/plugin-node-resolve": "^7.1.0", "@rollup/plugin-replace": "^2.2.1", - "@types/shelljs": "^0.8.5", + "@types/jest": "^24.0.15", "@typescript-eslint/eslint-plugin": "^2.12.0", "@typescript-eslint/parser": "^2.12.0", "ansi-escapes": "^4.2.1", @@ -102,7 +102,6 @@ "@types/eslint": "^6.1.2", "@types/execa": "^0.9.0", "@types/fs-extra": "^8.0.0", - "@types/jest": "^24.0.15", "@types/ms": "^0.7.30", "@types/node": "^13.1.0", "@types/ora": "^3.2.0", @@ -111,6 +110,7 @@ "@types/rollup-plugin-sourcemaps": "^0.4.2", "@types/sade": "^1.6.0", "@types/semver": "^7.1.0", + "@types/shelljs": "^0.8.5", "@types/styled-components": "^5.0.1", "autoprefixer": "^9.7.4", "babel-plugin-replace-identifiers": "^0.1.1", diff --git a/src/templates/basic.ts b/src/templates/basic.ts index a72fc884..baee6131 100644 --- a/src/templates/basic.ts +++ b/src/templates/basic.ts @@ -2,7 +2,7 @@ import { Template } from './template'; const basicTemplate: Template = { name: 'basic', - dependencies: ['@types/jest', 'husky', 'tsdx', 'tslib', 'typescript'], + dependencies: ['husky', 'tsdx', 'tslib', 'typescript'], packageJson: { // name: safeName, version: '0.1.0',