Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: allOf Validation errors missing #85

Open
elainaSutton opened this issue Nov 24, 2020 · 2 comments
Open

Bug: allOf Validation errors missing #85

elainaSutton opened this issue Nov 24, 2020 · 2 comments

Comments

@elainaSutton
Copy link

Hi Jarvelov
First of all thanks for your wonderful project!

I have a more complex use case where I use a base schema and implement this schema using the allOf feature.

Furthermore I have defined errorHandler divs to display the validation errors. Sadly for all fields that are defined in the base schema the validation errors are missing. The fields that are defined in the child schema do work properly.

I create a code sandbox which reproduces the error: https://codesandbox.io/s/allof-validation-errors-missing-cwszg

As you can see there the title property errors are not shown in contrast to the lead property.
The default example shows an invalid model. The valid property is correctly set to false but the error handler for the title never receives the errors.

Thx a lot for having a look 😃

@jarvelov
Copy link
Owner

Hi!

I see the issue but I haven't got time to dig into it right now. I think at a first glance that in this example it's likely that the $ref is the issue. Support for the $ref feature is something which I haven't really verified yet.

The issue might be because of the allOf keyword too, support for that is kinda patchy. I'll try to look into this tomorrow after work.

@jarvelov
Copy link
Owner

Hi again!

Life's gotten in the way and I have to spend my time away from VFJS for the next couple of weeks. More info here. I expect to be back in January 2021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants